Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplies logic to just forward to other methods, makes stats tracking consistent. #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplies logic to just forward to other methods, makes stats tracking consistent. #46

wants to merge 2 commits into from

Conversation

deckarep
Copy link
Contributor

  • Simplifying logic that's duplicated
  • Makes stats consistent with how they're getting cleared and locates them to a single method.

coocood
coocood reviewed Oct 17, 2018
View reviewed changes
segment.go Outdated
atomic.StoreInt64(&seg.hitCount, 0)
atomic.StoreInt64(&seg.missCount, 0)
atomic.StoreInt64(&seg.overwrites, 0)
atomic.StoreInt64(&seg.totalCount, 0)
atomic.StoreInt64(&seg.totalTime, 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalTime and totalCount is not stats.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Cache.ResetStatistics is called, we don't want to change them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for pointing that out. I will follow up with a fix.

@deckarep
Copy link
Contributor Author

@coocood - ok, finally got around to making the change. Please review and thank you.

coocood
coocood reviewed Oct 27, 2018
View reviewed changes
segment.go
atomic.StoreInt64(&seg.totalEvacuate, 0)
atomic.StoreInt64(&seg.totalExpired, 0)
atomic.StoreInt64(&seg.overwrites, 0)
atomic.StoreInt64(&seg.entryCount, 0)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deckarep @coocood